Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GET /v1/targeted-messaging/:outreachId/chains/:chainId/safes/:safeAddress #2343

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

iamacook
Copy link
Member

Partially resolves #2323

Summary

Targeted messaging currently targets Safes and signers (that have yet submitted responses).

This adds a new (GET /v1/targeted-messaging/:outreachId/chains/:chainId/safes/:safeAddress) route, returning a response should a safeAddress be targeted by a given outreachId.

type Response = {
  outreachId: number;
  address: `0x${string}`;
}

Changes

  • Add GET /v1/targeted-messaging/:outreachId/chains/:chainId/safes/:safeAddress route
  • Add new route-level TargetedSafe entity
  • Add appropriate test coverage

@iamacook iamacook self-assigned this Feb 12, 2025
@iamacook iamacook requested a review from a team as a code owner February 12, 2025 09:43
Copy link
Contributor

@PooyaRaki PooyaRaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: How do we make sure that the safe address does not appear in a campaign?

Copy link
Contributor

@PooyaRaki PooyaRaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only have a question but that's not a blocker so I'll approve it.

@iamacook
Copy link
Member Author

How do we make sure that the safe address does not appear in a campaign?

As per agreement, this will be used in conjunction with the existing feature flags of the Config Service (client-side). We intend to iterate on targeted features.

@iamacook iamacook merged commit 8cb2b5e into main Feb 13, 2025
18 checks passed
@iamacook iamacook deleted the feat/targeted-safe branch February 13, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Sub-Safes): create “Sub-Safe” outreach
2 participants