feat: optimize trusted contracts retrieval #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
approved these changes
Mar 6, 2025
iamacook
reviewed
Mar 6, 2025
src/datasources/transaction-api/transaction-api.service.spec.ts
Outdated
Show resolved
Hide resolved
| args.chainId, | ||
| ); | ||
| return trustedContracts.results.some((contract) => | ||
| isAddressEqual(contract.address, args.contractAddress), |
There was a problem hiding this comment.
Althought theoretically correct, I think we should still check the flag to be safe.
Suggested change
| isAddressEqual(contract.address, args.contractAddress), | |
| isAddressEqual(contract.address, args.contractAddress) && | |
| contract.trustedForDelegateCall,``` |
There was a problem hiding this comment.
Agreed. Even if it's not needed theoretically, we can check the flag to avoid the case the filter is not working properly on the Transaction Service for some reason. Thanks. Changed in 7e3b393
There was a problem hiding this comment.
Should we want to expose pages of contracts later on, we are also covered, e.g. we call a hypothetical getContracts method on the domain, passing the query there instead.
iamacook
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the addition of a new filter that makes it possible to get the complete list of trusted for delegate call contracts in the Transaction Service API, the Client Gateway can take advantage of it by caching that list and comparing proposals and transaction mappings against the list, instead of checking each contract on demand.
This PR adds a new function to retrieve the list, and checks against that list instead of calling
ContractRepository.getContractin bothTransactionDataMapperandSafeRepository.Changes
ContractRepository['isTrustedForDelegateCall']function.FF_TRUSTED_FOR_DELEGATE_CALL_CONTRACTS_LISTfeature flag.