fix: increase refinement test coverage #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Mar 6, 2025
Comment on lines
+156
to
+165
| if ( | ||
| !this.isEthSignEnabled && | ||
| signature.signatureType === SignatureType.EthSign | ||
| ) { | ||
| throw new HttpExceptionNoLog( | ||
| 'eth_sign is disabled', | ||
| MessageVerifierHelper.StatusCode, | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
This matches the pattern of other methods whereby we log unauthorized addreses as a priority.
iamacook
commented
Mar 6, 2025
| @@ -119,6 +119,9 @@ export class TransactionVerifierHelper { | |||
| ) { | |||
| throw new HttpExceptionNoLog(ErrorMessage.InvalidNonce, code); | |||
| } | |||
|
|
|||
| this.verifyApiTransaction(args); | |||
There was a problem hiding this comment.
We were trusting the API transaction as is whereas it should be verified in a similar manner as we do for the queue.
iamacook
commented
Mar 6, 2025
Comment on lines
+3
to
+10
| function isSignature(value: `0x${string}`): boolean { | ||
| // We accept proposals of singular or concatenated signatures | ||
| return (value.length - 2) % 130 === 0; | ||
| } | ||
|
|
||
| export const SignatureSchema = HexSchema.refine(isSignature, { | ||
| message: 'Invalid signature', | ||
| }); |
There was a problem hiding this comment.
By validating signature length, we prevent unnecessary verification from happening. This also has the added benefit that we get more descriptive error messages.
iamacook
commented
Mar 6, 2025
|
|
||
| const isBlocked = this.blocklist.includes(signature.owner); | ||
| const isBlocked = this.blocklist.some((blockedAddress) => { | ||
| return isAddressEqual(signature.owner, blockedAddress); |
There was a problem hiding this comment.
I think it was because of mock data but I came across some inconsistencies with non-checksummed addresses. As such, I migrated to using this helper in both verifiers to be safe.
hectorgomezv
approved these changes
Mar 7, 2025
src/routes/transactions/helpers/transaction-verifier.helper.spec.ts
Outdated
Show resolved
Hide resolved
hectorgomezv
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds extensive test coverage to refinement of proposal/confirmation and API transactions/messages. It also includes small fixes that we found due to adding test coverage.
Changes
TransactionVerifierandMessageVerifier