fix: ensure API signatures are even in length #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently validate that transaction signatures from our API are hex and a denomination fo 130 and that message signatures are hex.
Whilst we can be sure that incoming signatures from clients are a denomination of 130 (because the interface does not currently support proposal of contract signatures), we cannot be sure that the Transaction Service hasn't indexed contract signatures with dynamic parts.
This creates a new
HexBytesSchemawhich ensures a string is hex and even in length, aka "byte-aligned", applying it to the validation of transaction/message signatures from our API.Changes
HexBytesSchema