Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-kit): Add react native compatibility #1033

Open
wants to merge 20 commits into
base: development
Choose a base branch
from

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Oct 31, 2024

What it solves

Resolves #1026, #1027

How this PR fixes it

  • Creating a new static method to create the passkey signer
const credential = window.navigator.credentials.create(requestJson)
const passkeySigner = await createPasskeySigner(credential)
const protocolKit = await Safe.init({ provider, signer: passkeySigner })
  • Adding a getFn to the PasskeyArgType allowing the credential retrieval
type GetPasskeyCredentialFn = (
  options?: PasskeyCredentialRequestOptions
) => Promise<PasskeyCredential<PasskeyAuthenticatorAssertionResponse>>
  • Implementing a specific decoder for public keys coming from React Native

@yagopv yagopv linked an issue Oct 31, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11958802226

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.515%

Totals Coverage Status
Change from base Build 11742341140: 0.0%
Covered Lines: 786
Relevant Lines: 970

💛 - Coveralls

@dasanra dasanra changed the base branch from main to development November 5, 2024 11:40
@yagopv yagopv linked an issue Nov 21, 2024 that may be closed by this pull request
@yagopv yagopv self-assigned this Nov 21, 2024
@yagopv yagopv marked this pull request as ready for review November 21, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React Native] Passkey compatibility for Android devices [React Native] Add passkey compatibility for iOS
2 participants