-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update build for the whole repo #1047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontendphil
force-pushed
the
development
branch
from
November 13, 2024 11:15
46ee507
to
4c96ee9
Compare
frontendphil
force-pushed
the
development
branch
from
November 13, 2024 12:44
3fc1b6d
to
2acda8f
Compare
If I'd have read this comment #1043 (comment) 2hrs ago it would have saved me a lot of trouble :D |
@frontendphil Hey thanks for such work. Looks very promising. Yes don't worry about the remaining CI, secrets are not accessible from forks. We will do a review and bring the code to an integration branch to completely test CI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR updates the build for the whole repo.
How this PR fixes it
package/test-utils
entry point where necessarybaseUrl
property is set on the package level, which reduces the memory footprint of atsc
buildWhat is still open
Some
api-kit
tests started failing. AFAICT, this has something to do with thePRIVATE_KEY
environment variable not being set to the correct value. However, I wonder why this wasn't an issue earlier, and I also can't pinpoint a change I made that would result in this variable not being picked up correctly. I would appreciate help looking into this, as I think I've addressed all other issues.The build for
relay-kit
is also a bit weird because the tests in other packages needed to require deeply into this package to mock internals. That's not great, but to "properly" fix this, I think the general test setup needs to be adjusted, and that's definitely out of the scope of what I'm trying to achieve here.There is also one test in
protocol-kit
that now times out. But AFAICT it only does that on CI. When I run the tests locally, they all pass.