fix: redirect to old deployment for legacy Safes (#1096)

* fix: redirect to old deployment for legacy Safes

* fix: add tests

* fix: update param

* fix: test + adjust early return

* fix: extract constant + use `query` for Safe

* fix: remove unnecessary dependency

src/hooks/__tests__/useSafeNotifications.test.ts

@@ -20,7 +20,7 @@ jest.mock('../../hooks/useSafeInfo')
 // mock router
 jest.mock('next/router', () => ({
   useRouter: jest.fn(() => ({
-    query: { safe: 'rin:0x123' },
+    query: { safe: 'eth:0x123' },
   })),
 }))
 
@@ -56,13 +56,43 @@ describe('useSafeNotifications', () => {
         link: {
           href: {
             pathname: '/settings/setup',
-            query: { safe: 'rin:0x123' },
+            query: { safe: 'eth:0x123' },
           },
           title: 'Update Safe',
         },
       })
     })
 
+    it('should show a notification for legacy Safes', async () => {
+      // mock useSafeInfo to return a SafeInfo with an outdated version
+      ;(useSafeInfo as jest.Mock).mockReturnValue({
+        safe: {
+          implementation: { value: '0x123' },
+          implementationVersionState: 'OUTDATED',
+          version: '1.0.0',
+        },
+        safeAddress: '0x123',
+      })
+
+      // render the hook
+      const { result } = renderHook(() => useSafeNotifications())
+
+      // await
+      await act(async () => Promise.resolve())
+
+      // check that the notification was shown
+      expect(result.current).toBeUndefined()
+      expect(showNotification).toHaveBeenCalledWith({
+        variant: 'warning',
+        message: `Safe version 1.0.0 is not supported by this web app anymore. You can update your Safe via the old web app here.`,
+        groupKey: 'safe-outdated-version',
+        link: {
+          href: 'https://gnosis-safe.io/app/eth:0x123/settings/details?no-redirect=true',
+          title: 'Update Safe',
+        },
+      })
+    })
+
     it('should not show a notification when the Safe version is up to date', async () => {
       ;(useSafeInfo as jest.Mock).mockReturnValue({
         safe: {
@@ -89,6 +119,8 @@ describe('useSafeNotifications', () => {
       ;(useSafeInfo as jest.Mock).mockReturnValue({
         safe: {
           implementation: { value: '0x123' },
+          implementationVersionState: 'UP_TO_DATE',
+          version: '1.3.0',
         },
       })
       jest.spyOn(contracts, 'isValidMasterCopy').mockImplementation((...args: any[]) => Promise.resolve(false))
@@ -117,6 +149,8 @@ describe('useSafeNotifications', () => {
       ;(useSafeInfo as jest.Mock).mockReturnValue({
         safe: {
           implementation: { value: '0x456' },
+          implementationVersionState: 'UP_TO_DATE',
+          version: '1.3.0',
         },
       })
       jest.spyOn(contracts, 'isValidMasterCopy').mockImplementation((...args: any[]) => Promise.resolve(true))

src/hooks/useSafeNotifications.ts

@@ -5,8 +5,11 @@ import useSafeInfo from './useSafeInfo'
 import { useAppDispatch } from '@/store'
 import { AppRoutes } from '@/config/routes'
 import useAsync from './useAsync'
-import { isOldestVersion, isValidMasterCopy } from '@/services/contracts/safeContracts'
+import { isValidMasterCopy } from '@/services/contracts/safeContracts'
 import { useRouter } from 'next/router'
+import { isValidSafeVersion } from './coreSDK/safeCoreSDK'
+
+const OLD_URL = 'https://gnosis-safe.io/app'
 
 const CLI_LINK = {
   href: 'https://github.com/5afe/safe-cli',
@@ -31,26 +34,26 @@ const useSafeNotifications = (): void => {
       return
     }
 
-    const isOldSafe = isOldestVersion(version)
+    const isOldSafe = !isValidSafeVersion(version)
 
     const id = dispatch(
       showNotification({
         variant: 'warning',
         groupKey: 'safe-outdated-version',
 
         message: isOldSafe
-          ? `Safe version ${version} is not supported by this web app anymore. We recommend using the command line interface instead.`
+          ? `Safe version ${version} is not supported by this web app anymore. You can update your Safe via the old web app here.`
           : `Your Safe version ${version} is out of date. Please update it.`,
 
-        link: isOldSafe
-          ? CLI_LINK
-          : {
-              href: {
+        link: {
+          href: isOldSafe
+            ? `${OLD_URL}/${query.safe}/settings/details?no-redirect=true`
+            : {
                 pathname: AppRoutes.settings.setup,
                 query: { safe: query.safe },
               },
-              title: 'Update Safe',
-            },
+          title: 'Update Safe',
+        },
       }),
     )
 

src/services/contracts/safeContracts.ts

@@ -54,7 +54,7 @@ export const getSpecificGnosisSafeContractInstance = (safe: SafeInfo) => {
   })
 }
 
-export const isOldestVersion = (safeVersion: string): boolean => {
+const isOldestVersion = (safeVersion: string): boolean => {
   return semverSatisfies(safeVersion, '<=1.0.0')
 }