Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx execution and safe creation cannot be done with Ledger Nano S #4041

Closed
francovenica opened this issue Aug 6, 2024 · 7 comments
Closed
Assignees
Labels
major Major bug (to be solved in the next release)

Comments

@francovenica
Copy link
Contributor

francovenica commented Aug 6, 2024

Bug description

Trying to create a tx shows an error when trying to sign
Trying to execute a tx shows an error regarding enabling blind signing, but the blind signing is enabled. Tried with adding an owner, sending funds, trying to execute a spending limit usage

There is NO issue signing tx, proposing tx or signing messages
None of this issues happen with a Ledger X

Environment

  • Browser: Chrome
  • Wallet: native ledger nano S
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Try to create a safe with "Pay now" option using a ledger Nano S
  2. Try to execute a tx in a safe with a ledger nano S

Expected result

Safe creation and execution should be possible like any other wallet

Screenshots

image
image

@francovenica francovenica added bug major Major bug (to be solved in the next release) labels Aug 6, 2024
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Aug 6, 2024
@schmanu
Copy link
Member

schmanu commented Aug 12, 2024

I just tried Safe creation with my ledger imported through metamask without any issues.
So we can def. suggest that as a workaround.

@francovenica you put MetaMask into the environment of this ticket. But I guess you are not actually using Ledger through Metamask here? Could you put the correct environment to reproduce?

@schmanu
Copy link
Member

schmanu commented Aug 12, 2024

@francovenica
Even when using Ledger directly without MetaMask I was able to create a Safe, sign and execute transactions.
Which version are you running in your Ledger including the version of your Ethereum Application.
I am running Ethereum version 1.10.2

@schmanu schmanu self-assigned this Aug 12, 2024
@schmanu schmanu moved this from New issues to In Progress in Safe{Wallet} Aug 12, 2024
@schmanu
Copy link
Member

schmanu commented Aug 12, 2024

@francovenica
this is an issue with the new ledger firmware.
There are other users reporting similar errors for other txs: e.g. LedgerHQ/app-ethereum#311

I found this workaround that seems to fix it for some users: https://community.metamask.io/t/ledger-issue-please-enable-contract-data-but-its-already-enabled-and-enabling-debug-data-fixes-it/9679/3
Could you try that?
I think its not an issue with Safe{Wallet} though.

@francovenica
Copy link
Contributor Author

@schmanu Sorry for taking so long to get back to this.

I tried with debug enabled and even with that still fails:
I get this error when trying to do a "Send funds".
I also get an error when I'm tryin got create a safe

image

@schmanu
Copy link
Member

schmanu commented Sep 9, 2024

We have to wait for a new firmware version. I think this is a bug in the ledger firmware.

@francovenica
Copy link
Contributor Author

francovenica commented Sep 10, 2024

Edited the description to point out this issue is with the native Ledger Nano S connection, not a MM import of that wallet.
I think that, if this is not a safe's issue, we should close this with a "won't fix".

@liliya-soroka
Copy link
Member

Verified with the latest firmware version : execution and safe creation via Ledger Nano S direct connection work as expected

@github-project-automation github-project-automation bot moved this from In Progress to Done in Safe{Wallet} Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major bug (to be solved in the next release)
Projects
Archived in project
Development

No branches or pull requests

3 participants