Add role auth #32
Merged
Add role auth #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's ready for review after many refactoring and boiled down to the agreed essentials only. Things which should be improved for future (after pilot?):
Things which could be improved:
Open question for after pilot:
|
nathanstitt
reviewed
Nov 14, 2024
src/middleware.ts
Outdated
| // Define user roles | ||
| const userRoles = { | ||
| isAdmin: orgId === SAFEINSIGHTS_ORG_ID, | ||
| isOpenStaxMember: orgId === OPENSTAX_ORG_ID, |
There was a problem hiding this comment.
I think we should use org slugs vs ids. The ids will change across clerk instances and if we ever accidentally destroy an org and recreate it later, but we can control the slugs so they'd stay the same.
| }, | ||
| } | ||
|
|
||
| export default logger |
There was a problem hiding this comment.
I like this, but maybe we pull in a "real" logging library that allows filtering and prefixes? I've used https://www.npmjs.com/package/debug before and liked it's functionality
nathanstitt
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/OTTER-36
It's in regards to the 403 pages a MVP. But the focus is more that members cannot be researchers and vice versa (protect routes). Also non logged in users should not access any member or researcher pages (which before this PR was possible). The 403 page could definitely look "nice" or "styled". If that's needed on top I would prefer to built on top of this PR.