Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display CSV file results #38

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Display CSV file results #38

merged 7 commits into from
Nov 21, 2024

Conversation

nathanstitt
Copy link
Member

image

@nathanstitt nathanstitt requested a review from a team November 20, 2024 20:52
Copy link
Contributor

@therealmarv therealmarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good and nice :)

Small thing to maybe fix: __ variable name usage

const queryClient = useQueryClient()
const [viewingRunId, setViewingRunId] = useState<string | null>(null)
const [__, setViewingRunId] = useState<string | null>(null)
Copy link
Contributor

@therealmarv therealmarv Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__ variable does not explain a lot. Is it maybe a typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, _ is just a "unused var" that is exluded from aslant rules. I need to figure out what's going on with that setState since it doesn't appear used at all

@nathanstitt nathanstitt merged commit ebaa163 into main Nov 21, 2024
1 check passed
@nathanstitt nathanstitt deleted the csv-preview branch November 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants