-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display CSV file results #38
Conversation
nathanstitt
commented
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good and nice :)
Small thing to maybe fix: __
variable name usage
const queryClient = useQueryClient() | ||
const [viewingRunId, setViewingRunId] = useState<string | null>(null) | ||
const [__, setViewingRunId] = useState<string | null>(null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__
variable does not explain a lot. Is it maybe a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, _
is just a "unused var" that is exluded from aslant rules. I need to figure out what's going on with that setState since it doesn't appear used at all