Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otter 51 researcher step 2 #41

Closed
wants to merge 28 commits into from
Closed

Otter 51 researcher step 2 #41

wants to merge 28 commits into from

Conversation

jbwilson8
Copy link
Contributor

@jbwilson8 jbwilson8 commented Dec 2, 2024 •
edited by jira bot
Loading

@jbwilson8 jbwilson8 requested a review from a team December 2, 2024 21:23
nathanstitt and others added 12 commits December 9, 2024 10:09
@nathanstitt
Merge pull request #39 from safeinsights/fixes-for-demo
21ca403 
Misc fixes for demo
@jbwilson8
remove logic around "View Instructions" button
6ac8b16 
per spec, "View Instructions" button should always be visible in the code run review panel
@jbwilson8
linting
bc28e5c
@jbwilson8
remove typo
c269170
@jbwilson8
re-add code that was removed as a result of the previous revert change
c7856aa
@jbwilson8
Merge branch 'OTTER-51-Researcher-Step-2' of https://github.com/safei…
73f1969 
…nsights/management-app into OTTER-51-Researcher-Step-2
@jbwilson8
Revert "Merge branch 'OTTER-51-Researcher-Step-2' of https://github.c…
7e8d6f0 
…om/safeinsights/management-app into OTTER-51-Researcher-Step-2"

This reverts commit 73f1969, reversing
changes made to c7856aa.
@jbwilson8
remove logic around "View Instructions" button
f955c62 
per spec, "View Instructions" button should always be visible in the code run review panel
@jbwilson8
rebase
d2351b8
@jbwilson8
linting
eb6bed3
@jbwilson8
remove typo
8126b55
@jbwilson8
revert change
23b6e75
@jbwilson8
Copy link
Contributor Author

After much diffing it looks like the only change that this PR would introduce is increasing the size of the "View Instructions" modal (line 82 in runs-table.tsx size={800}) The rest of the requirements for OTTER-51 are handled in the PR for OTTER-50, the PR for misc fixes for demo, and this PR. I've created a new PR (as discussed in this morning's sync) to accommodate this change and will make note of these things in the OTTER-51 jira card.

@jbwilson8 jbwilson8 closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealmarv therealmarv therealmarv approved these changes

@nathanstitt nathanstitt nathanstitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbwilson8 @nathanstitt @therealmarv