Added docker build & push scripts to package.json
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnathuji
reviewed
Jan 21, 2025
|
|
||
| aws ecr get-login-password --region "$AWS_REGION" | docker login --username AWS --password-stdin "$AWS_ACCOUNT".dkr.ecr."$AWS_REGION".amazonaws.com | ||
| docker build -t "$DOCKER_IMAGE" . | ||
| aws ecr describe-repositories --repository-names setup-app --profile $AWS_PROFILE --region $AWS_REGION || aws ecr create-repository --repository-name setup-app --profile "$AWS_PROFILE" --region "$AWS_REGION" |
There was a problem hiding this comment.
🤔 -- This kind of conflicts (or at least muddies the water IMHO) with the "ownership" of creating repositories in the IAC here. Are we okay with that?
There was a problem hiding this comment.
In the TOA we have the repository creation, image build and push as part of the npm scripts, which I assume aims to easy build and deployment for devs, but we can bring it up tomorrow with the team and see how we want to go about it and how that can work with future CI-CD pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docker build & push scripts to
package.json