Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests with Mocked objects #25

Merged
merged 3 commits into from
Jul 30, 2024
Merged

add tests with Mocked objects #25

merged 3 commits into from
Jul 30, 2024

Conversation

philschatz
Copy link
Collaborator

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just adding some thoughts as I read through this - this seems like something that is easily handled by playwright, ie

  • go to page
  • don't log in
  • expect the URL to have been redirected

we will most likely have tests like this that cover this expected behavior, i think im just feeling a little dumb on what a unit test might actually "mean". i always thought of unit tests as testing 1 thing and 1 thing only

i also wonder a lot about mocking, if we are mocking these objects to be exactly what we want - are these good representations of how the actual components/clerk objects might be working?

just thinking out loud here, but there will be some duplicated tests i imagine at some point, maybe thats totally fine though?

@philschatz philschatz merged commit 69b4907 into main Jul 30, 2024
1 check passed
@philschatz philschatz deleted the phil-tests branch July 30, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants