Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SubgraphSearch robust to vertex labels #35904

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Jul 5, 2023

Part of #35902.

📚 Description

We ensure that the method operates properly even when vertices and edges are of incomparable types.

On the way, we also avoid a call to adjacency_matrix.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert
Copy link
Contributor Author

It seems I did something wrong when trying to rebase on last beta. This PR should modify only file src/sage/graphs/generic_graph_pyx.pyx... Any advise is more than welcome.

@mkoeppe mkoeppe force-pushed the graphs/improve_subgraph_search branch from 6c8f49f to d12921a Compare July 21, 2023 20:42
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 21, 2023

Rebased

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcoudert
Copy link
Contributor Author

Thank you.

@github-actions
Copy link

Documentation preview for this PR (built with commit d12921a; changes) is ready! 🎉

@vbraun vbraun merged commit 4eb3fcb into sagemath:develop Jul 30, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants