Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algorithms related to generalized palindromes and palindromic defects #36990

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Algorithms related to generalized palindromes and palindromic defects #36990

wants to merge 37 commits into from

Conversation

giovanni-romanenko
Copy link

@giovanni-romanenko giovanni-romanenko commented Jan 2, 2024 •
edited
Loading

Added new method to compute G-defect, improved performance of existing method computing data related to palindromic substrings and palindromic defect, and did some refactoring in same scope

Fixes #35495 and #16366

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Ivan Romanenko and others added 26 commits June 3, 2023 20:57
Some changes in morphism.py and making notes in finite_word.py
1ae186c
Added a new reference, preparations for adding algorithm for getting …
2fa6b85 
…palindrome data
Some fixes and preparations
30f7084
Finished main algorithm for getting palindromic factors data in linea…
4167122 
…r time
Fixed tests for one private method
d21d8ad
Finished everything expect algorithms for G-defect
4df86f5
Added new reference and working on G-defect
854fce6
Small work on G-defect algorithm
aba6c54
Testing and fixes
6eafe1c
Almost finished G-defect algorithm
4c35ef7
Finished G-defect algorithm
8066758
Added tests for G-defect
d4787ad
Added reference to my bachelor thesis to all required places
a7c2b3d
Added link to my bachelor thesis
17915f3
Small research on what is left to be done
ba72fcd
Decided not to add tests for one of private methods
c3778f0
Fixed computation of g_w in defect()
3833338
Refactoring generation of unused letters
9bc6eb3
Finished with refactoring algorithms for defect and g_defect
b09d636
Merge remote-tracking branch 'sagemath/develop' into develop
b7c4ace
Merge remote-tracking branch 'sagemath/develop' into develop
84d1c22
Codestyle fixes
6a503ac
Codestyle fixes
215918e
Fixed performance issue for palindromes method
f10122c
Merge remote-tracking branch 'sagemath/develop' into develop
e7d63db
@giovanni-romanenko
Merge branch 'develop' into develop
ebae12d
@tscrim
Copy link
Collaborator

tscrim commented Jan 5, 2024

@videlec I believe you have done some of the coding on the words. Do you have any comments and/or are willing to do a review here? Otherwise I will try to review this soon.

@videlec
Copy link
Contributor

videlec commented Jan 5, 2024

@seblabbe did most of it.

@seblabbe
Copy link
Contributor

seblabbe commented Jan 6, 2024

Travis if you have time soon to look into this, I let you do it. Thank you.

@fchapoton
Update finite_word.py
3d6641a 
trying to fix latex compilation
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Documentation preview for this PR (built with commit daaf2f3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Jan 17, 2024

I will try to look at this soon, but I am not sure exactly when I will have time.

@giovanni-romanenko
Copy link
Author

@tscrim @videlec @seblabbe Hi, folks! Any updates on the review status of this pull request?

fchapoton
fchapoton reviewed Jan 27, 2025
View reviewed changes
src/sage/combinat/words/finite_word.py
every antimorphism of `G`.

OUTPUT:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add doctests even in private methods, please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchapoton Fixed

fchapoton
fchapoton reviewed Jan 30, 2025
View reviewed changes
src/sage/combinat/words/finite_word.py
a list -- list of all the lacunas of ``self`` in ascending order.

EXAMPLES::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctests should be indented by 4 spaces

Copy link
Author

@giovanni-romanenko giovanni-romanenko Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchapoton Fixed

@giovanni-romanenko
Copy link
Author

@fchapoton Added fixes for pycodestyle-minimal and ruff-minimal

@giovanni-romanenko
Copy link
Author

@fchapoton Added fixes for RST checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton left review comments

Assignees
No one assigned
Labels
c: combinatorics s: needs review v: large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Algorithms related to generalized palindromes and palindromic defects
6 participants
@giovanni-romanenko @tscrim @videlec @seblabbe @fchapoton @mkoeppe