Fix comment on ginac NegInfinity constant #39138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit a070310; changes) is ready! 🎉 |
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 25, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The comment on ginac's `NegInfinity` constant (lines 374-375 of `src/sage/symbolic/ginac/infinity.cpp` is a duplicate of the comment on `Infinity`: ``` /** Infinity, i.e., positive infinity. * Calls python function py_eval_infinity for evalf(). */ const infinity Infinity = infinity::from_sign(+1); /** Infinity, i.e., positive infinity. * Calls python function py_eval_infinity for evalf(). */ const infinity NegInfinity = infinity::from_sign(-1); ``` That is not correct for `NegInfinity`, so this PR changes the comment for `NegInfinity` to: ``` /** NegInfinity, i.e., negative infinity. * Calls python function py_eval_neg_infinity for evalf(). */ ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39138 Reported by: DaveWitteMorris Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment on ginac's
NegInfinityconstant (lines 374-375 ofsrc/sage/symbolic/ginac/infinity.cppis a duplicate of the comment onInfinity:That is not correct for
NegInfinity, so this PR changes the comment forNegInfinityto:📝 Checklist
⌛ Dependencies