Addition of Kähler algebras as a category #39168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 78dfd70; changes) is ready! 🎉 |
tscrim
requested changes
Dec 19, 2024
|
Once the bot comes back green, you can set a positive review. |
|
One new (annoying) thing I think needs to be done is adding new files to the |
tscrim
reviewed
Jan 11, 2025
|
Thank you. Looks good now. |
|
Why is sage_categories-check still failing? |
|
I've seen it failing on many PRs. It contains no information about what is going on, nor can I find any info about it. Thus I completely ignore it. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This PR adds Kähler algebras as a category `KahlerAlgebras` as defined in Theorem 2.28 of [this paper](https://arxiv.org/abs/2309.14312). It changes the category of Chow rings to `KahlerAlgebras() & CommutativeRings().Quotients()`. A method, `lefschetz_element()` is also implemented for Chow rings which returns a Lefschetz element as provided in Corollary 2.30 of the paper above, which is used for the Hodge- Riemann relations computation. @tscrim ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39168 Reported by: 25shriya Reviewer(s): 25shriya, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This PR adds Kähler algebras as a category `KahlerAlgebras` as defined in Theorem 2.28 of [this paper](https://arxiv.org/abs/2309.14312). It changes the category of Chow rings to `KahlerAlgebras() & CommutativeRings().Quotients()`. A method, `lefschetz_element()` is also implemented for Chow rings which returns a Lefschetz element as provided in Corollary 2.30 of the paper above, which is used for the Hodge- Riemann relations computation. @tscrim ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39168 Reported by: 25shriya Reviewer(s): 25shriya, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Kähler algebras as a category
KahlerAlgebrasas defined in Theorem 2.28 of this paper. It changes the category of Chow rings toKahlerAlgebras() & CommutativeRings().Quotients(). A method,lefschetz_element()is also implemented for Chow rings which returns a Lefschetz element as provided in Corollary 2.30 of the paper above, which is used for the Hodge-Riemann relations computation.@tscrim
📝 Checklist
⌛ Dependencies