Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ci-conda-yml workflow file #39240

Closed
wants to merge 3 commits into from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Jan 1, 2025

  • use the trick to allow simple listing of configurations that are included in pull request. (specifically it works as follows: in a pull_request, is-pull-request variable is true, thus exclude: {is-pull-request: true} will delete all the normal ones, then include: is processed. In a branch (not pull request), the exclude does nothing, and the include also does nothing since there are already these options. )
  • change success() || failure() to !cancelled() to avoid confusion.

edit: supposedly the conda CI workflow is going away "very soon" though (#39176 (comment)). May be not worth it.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

⌛ Dependencies

@user202729 user202729 mentioned this pull request Jan 1, 2025
5 tasks
Copy link

github-actions bot commented Jan 1, 2025

Documentation preview for this PR (built with commit c2bd9aa; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant