Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson: build groups even without gap #39278

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

group.pyx compiles fine also without gap installed.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jan 4, 2025

Documentation preview for this PR (built with commit 47a5173; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez requested a review from dimpase January 9, 2025 10:31
`group.pyx` compiles fine also without gap installed.
@dimpase dimpase force-pushed the meson-groups-deps-improv branch from 687fe36 to 47a5173 Compare January 9, 2025 19:37
@dimpase
Copy link
Member

dimpase commented Jan 9, 2025

This is confusing - I gather you need GAP headers to compile things in src/sage/libs/gap/, no?

@tobiasdiez
Copy link
Contributor Author

This is confusing - I gather you need GAP headers to compile things in src/sage/libs/gap/, no?

Sure, but where we are in the groups directory ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants