-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some fixes after cython-lint #39346
Open
fchapoton
wants to merge
1
commit into
sagemath:develop
Choose a base branch
from
fchapoton:cylint_varia
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
some fixes after cython-lint #39346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit 335728d; changes) is ready! 🎉 |
kwankyu
reviewed
Jan 19, 2025
kwankyu
reviewed
Jan 19, 2025
kwankyu
reviewed
Jan 19, 2025
dimpase
suggested changes
Jan 19, 2025
fchapoton
force-pushed
the
cylint_varia
branch
from
January 20, 2025 08:38
1877717
to
335728d
Compare
kwankyu
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 23, 2025
a few fixes in pyx files, according to suggestions of `cython-lint` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39346 Reported by: Frédéric Chapoton Reviewer(s): Dima Pasechnik, Frédéric Chapoton, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 25, 2025
a few fixes in pyx files, according to suggestions of `cython-lint` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39346 Reported by: Frédéric Chapoton Reviewer(s): Dima Pasechnik, Frédéric Chapoton, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 26, 2025
a few fixes in pyx files, according to suggestions of `cython-lint` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39346 Reported by: Frédéric Chapoton Reviewer(s): Dima Pasechnik, Frédéric Chapoton, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few fixes in pyx files, according to suggestions of
cython-lint
📝 Checklist