remove attempt to coerce scalar to basering for truediv #39371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was observed in #39318, presently division of general univariate polynomials first tries to convert the dividing element into the base ring and invert it there. That's a problem with something like
QQ['x']['y']
and computingy/1
: the scalar1
gets coerced intoQQ['x']
and computing its inverse there yields an element in the field of fractions ofQQ['x']
. The parent of the result is therefore the polynomial ring iny
over that.The coercion framework is capable of finding an action of
QQ
onQQ['x']['y']
, so if we just leave it to the coercion framework, we end up with a tighter parent for the result. Preliminary timings indicate that there is no significant performance regression, but more detailed timing might be warranted.📝 Checklist
⌛ Dependencies