Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline an inner function in random two-sphere (for speed) #39380

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

fchapoton
Copy link
Contributor

to avoid a function call, in order to get a little more speed

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

Documentation preview for this PR (built with commit 35df246; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert
Copy link
Contributor

The change is in method RandomTriangulation of src/sage/graphs/generators/random.py, so why is this PR pointing to random two-sphere ?

@fchapoton
Copy link
Contributor Author

well, this is a random triangulation of the two-sphere..

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 28, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 31, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
…speed)

    
to avoid a function call, in order to get a little more speed

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39380
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 844c7d6 into sagemath:develop Feb 10, 2025
24 checks passed
@fchapoton fchapoton deleted the random_2_sphere branch February 11, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants