-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversion of symmetric functions to and from magma #39403
base: develop
Are you sure you want to change the base?
Conversation
working, now this needs doctests |
bf4ecec
to
3da3354
Compare
Documentation preview for this PR (built with commit 24cd34a; changes) is ready! 🎉 |
now with doctests, ready for review |
@tscrim : Hello Travis. Would you by chance have enough time to approve this one ? I have tested with magma and all tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Let's get this in.
Thanks a lot ! When you can, maybe you can also look at #38794 ? |
as this can be useful ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39403 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
as this can be useful ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39403 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
as this can be useful ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39403 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
as this can be useful ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39403 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
as this can be useful
📝 Checklist