Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion of symmetric functions to and from magma #39403

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

as this can be useful

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@fchapoton fchapoton marked this pull request as draft January 28, 2025 14:26
@fchapoton
Copy link
Contributor Author

working, now this needs doctests

Copy link

github-actions bot commented Jan 28, 2025

Documentation preview for this PR (built with commit 24cd34a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton fchapoton marked this pull request as ready for review January 28, 2025 16:58
@fchapoton
Copy link
Contributor Author

now with doctests, ready for review

@fchapoton fchapoton changed the title starting conversion of symmetric functions to and from magma conversion of symmetric functions to and from magma Jan 28, 2025
@fchapoton
Copy link
Contributor Author

@tscrim : Hello Travis. Would you by chance have enough time to approve this one ? I have tested with magma and all tests pass.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Let's get this in.

@fchapoton
Copy link
Contributor Author

Thanks a lot ! When you can, maybe you can also look at #38794 ?

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2025
    
as this can be useful

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39403
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 31, 2025
    
as this can be useful

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39403
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
    
as this can be useful

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39403
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
    
as this can be useful

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39403
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants