Computing genus of a curve: bugfix (addresses #28336) #39453
Conversation
|
Checking geometric irreducibility takes a nontrivial time. Hence the The WARNING section, you are deleting, explains it clearly. |
|
We may close #28336 as already "fixed" |
| - ``base_ring`` -- the base ring of the divisor group; usually, this is | ||
| `\ZZ` (default) or `\QQ` | ||
| - ``base_ring`` -- the base ring of the divisor group. Usually, this is | ||
| `\ZZ` (default) or `\QQ`. | ||
|
|
There was a problem hiding this comment.
no, your changes here are not correct. The input entries are not sentences, and should have no final dot
There was a problem hiding this comment.
A semicolon is not correct for the same reason, since it is not joining two related independent clauses. I don't care that much and just reverted it.
src/sage/schemes/curves/curve.py
Outdated
| @@ -224,7 +264,14 @@ def geometric_genus(self): | |||
| sage: C.geometric_genus() | |||
| 3 | |||
|
|
|||
| Examples of affine curves:: | |||
| Addressing issue #28336 | |||
There was a problem hiding this comment.
de-indent this line, add :: at then end and an empty line after it
)
The code to compute the genus of a curve first checks that the given curve is geometrically irreducible and throws an error if it is not.
Fixes #28336.
📝 Checklist
⌛ Dependencies