Fix: External env vars are detected as cycles #911

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ### v0.36.13
 
+* Fix: External env vars are detected as cycles #911
 * Fix: Auto complete bash script #914 (thanks @gw31415)
 * Documentation: Arch Linux installation #880 (thanks @CosminGGeorgescu)
 * Documentation: Fix Readme about Binary Release Target #915 (thanks @Azuki-bar)

src/lib/cli.rs

@@ -99,15 +99,9 @@ fn run(cli_args: CliArgs, global_config: &GlobalConfig) {
 
     let config = match descriptor_load_result {
         Ok(config) => config,
-        Err(ref min_version) => {
-            error!(
-                "{} version: {} does not meet minimum required version: {}",
-                &cli_args.command, &VERSION, &min_version
-            );
-            panic!(
-                "{} version: {} does not meet minimum required version: {}",
-                &cli_args.command, &VERSION, &min_version
-            );
+        Err(ref error) => {
+            error!("{}", error);
+            panic!("{}", error);
         }
     };
     let mut time_summary_vec = vec![];

src/lib/descriptor/env.rs

@@ -142,8 +142,10 @@ pub(crate) fn merge_env(
 
         // if the env variable is in the current scope add an edge,
         // otherwise it is referencing an external variable.
+        // also, ignore self reference (such as PATH=${PATH})
+        let is_external = envmnt::exists(&key);
         for used in env_depends_on(val).into_iter() {
-            if graph.contains_node(used) {
+            if (key != &used || !is_external) && graph.contains_node(used) {
                 graph.add_edge(*key, used, ());
             }
         }