Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-command alternative to the readme #937

Merged

Conversation

janosimas
Copy link

fix #923

@sagiegurari
Copy link
Owner

@janosimas thanks for this and docs are great, but can you do a minor fix?
the readme.md is actually generated from both nav.md and content.md.
you need to update those files and not the readme file otherwise your content will be deleted.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -22.94% ⚠️

Comparison is base (098cef8) 92.88% compared to head (b13dbcc) 69.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #937       +/-   ##
===========================================
- Coverage   92.88%   69.94%   -22.94%     
===========================================
  Files         118      118               
  Lines       23727    23657       -70     
===========================================
- Hits        22038    16547     -5491     
- Misses       1689     7110     +5421     

see 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sagiegurari
Copy link
Owner

@janosimas just making sure you saw my comment

@janosimas
Copy link
Author

Hi @sagiegurari , sorry, it has been some hectic days.
It is in my todo list.

@janosimas
Copy link
Author

I rebased and updated nav.md and content.md

@sagiegurari
Copy link
Owner

@janosimas this is great, thanks a lot.
will merge and generate the readme later today

@sagiegurari sagiegurari merged commit 8bfc1c1 into sagiegurari:master Sep 18, 2023
13 of 14 checks passed
@janosimas janosimas deleted the doc/subcommand-alternative branch September 19, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub-command docs improvement
2 participants