Add unit test for multiple WAL consumers concurrently do synchronization #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
bozorgzadeh
reviewed
Jul 27, 2022
| // Start WAL consumers. | ||
| WalConsumer[] consumers = new WalConsumer[numConsumers]; | ||
| for (int i = 0; i < numConsumers; i++) { | ||
| consumers[i] = new WalConsumer(TestWalEntity.class, this::synchronizeModel, sessionFactory, "my_app"); |
There was a problem hiding this comment.
We can not check the order using HashMap, so for this test, it is better to use a Vector or CopyOnWriteArrayList (which are thread-safe) and check the exact order on them. So please define two methods: synchronizeMap (for the first test) and synchronizeVector (for the second test). Also rename the data structures to targetMap and targetVector.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for multiple WAL consumers concurrently do synchronization