WIP Whisper Websocket #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @chrismbirmingham. Any reason you've added a new folder with a separate |
|
I left app.py as it was in case you care about react vs fastapi. main.py isn't the cleanest code I have ever written but it works. Let me know if you have any questions, but otherwise I'll probably be taking this in a more interactive direction. |
nomionz
reviewed
Mar 1, 2023
Comment on lines
+86
to
+93
| if start<=10: | ||
| if start == 5: | ||
| first_data = first_bytes+joined_data | ||
| data_bytes = io.BytesIO(first_data) | ||
| audio_clip = AudioSegment.from_file(data_bytes, codec='opus') | ||
| rms_threshold = audio_clip.rms * (1+rms_increase) | ||
| print("RMS Threshold = ", rms_threshold) | ||
| start+=1 |
There was a problem hiding this comment.
Can't figure out what the purpose of this if statement is?
There was a problem hiding this comment.
Is it for making a 10 seconds chunk of audio?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a working websocket with fastAPI. I am still learning react so I'll update that connection after I play around a bit more. If you have any suggestions beyond adding another button for "live" transcription comments and feedback are welcome.