Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Clang/Xcode and support Kerberos on macOS #280

Closed
wants to merge 10 commits into from
Closed

Support Clang/Xcode and support Kerberos on macOS #280

wants to merge 10 commits into from

Conversation

amosavian
Copy link
Contributor

This pull request adds module.modulemap to allow clang to treat this library as
a framework, allowing use of "import" rather than include and provides better
support for Swift binding.

Also krb5wrapper has been modified to support macOS.
I've disabled a section of code as gss_set_neg_mechs() is not defined on macOS.

Please note I've changed two cases of angled-bracket include to double-quoted one
as it did not compile on my computer. I hope it won't break anything on other systems.

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 26, 2023

This pull request adds module.modulemap to allow clang to treat this library as a framework, allowing use of "import" rather than include and provides better support for Swift binding.

Also krb5wrapper has been modified to support macOS. I've disabled a section of code as gss_set_neg_mechs() is not defined on macOS.

Please note I've changed two cases of angled-bracket include to double-quoted one as it did not compile on my computer. I hope it won't break anything on other systems.

Hey there, could you try to merge to the latest branch?

@amosavian
Copy link
Contributor Author

@Wolf3s Would you mind checking again?

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 28, 2023

@Wolf3s Would you mind checking again?

Yeah, i will check soon also maybe i do some patches til then.

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 28, 2023

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 29, 2023

It works pretty well now, i think @sahlberg would merge this one.

@sahlberg
Copy link
Owner

It needs some more changes.
The include files that are installed into /usr/include/smb2 should not change to use #include "" to include the other files that also end up in /usr/include/smb2. They should continue to use #include <>

@Wolf3s
Copy link
Contributor

Wolf3s commented Nov 30, 2023

It needs some more changes. The include files that are installed into /usr/include/smb2 should not change to use #include "" to include the other files that also end up in /usr/include/smb2. They should continue to use #include <>

i´ve added #include <> it should work on mac os normally.

@amosavian
Copy link
Contributor Author

When I use Swift Package Manager, so no headers would be found on /usr/include/smb2 and I don't know how to resolve this issue. @sahlberg

@amosavian
Copy link
Contributor Author

I will close and reopen another PR in order to change source branch @Wolf3s @sahlberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants