[sailfish-browser] Virtualize background tabs when another application is opened #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
force-pushed
the
virtualizeOnBackground
branch
from
654ecb5 to
43b72e8
Compare
src/webpages.cpp
Outdated
| { | ||
| // In Switcher. | ||
| if (!m_webContainer->foreground()) { | ||
| m_backgroundTimestamp = QDateTime::currentMSecsSinceEpoch(); |
There was a problem hiding this comment.
When the browser is semi-permanently on background, the timestamp is updated on every backgroundChanged(). That prevents the memory-pressure notification and is a small behavior change not described in the commit.
There was a problem hiding this comment.
True that. Will later PR.
…n is opened Current implementation virtualizes backgrounded tabs when low memory notification (warning / critical) is received even if the browser is at foreground. Virtualizing backgrounded tabs when another application is brought foreground guarantees that there are no background tabs when another application is running regardless of low memory notification.
rainemak
force-pushed
the
virtualizeOnBackground
branch
from
43b72e8 to
32b0f43
Compare
|
Updated. |
| if (!m_webContainer->foreground()) { | ||
| m_backgroundTimestamp = QDateTime::currentMSecsSinceEpoch(); | ||
| } | ||
| } | ||
|
|
||
| /*! | ||
| * Virtualize pages that are inactive (all but the first). | ||
| * This also takes a time stamp that is later used to |
There was a problem hiding this comment.
Oops. This sentence got copied here as well. Should not be here.
Another way to implement this kind of early release would be to do this when screen is dimmed meaning that browser goes to background and it is not requesting screen to be on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation virtualizes backgrounded tabs when low memory
notification (warning / critical) is received even if the browser is
at foreground. Virtualizing backgrounded tabs when another application
is brought foreground guarantees that there are no background tabs
when another application is running regardless of low memory
notification.