Lazy-load toolbar features to improve launch performance #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2018 12:17
…il actual search. Contributes to JB#42700
jpetrell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable savings I would have gotten if I had postponed the component compilations too, but that is pointless since Qt 5.9 compile caching is coming.
Postpones few hundred of milliseconds of view delegate creations, which are already asynchronous so doesn't improve launch time that much (maybe 40-80ms), but also frees bandwidth for the initial page construction.
During system load introduces some flicker as you can sometimes see the favorite grid item icons appearing in steps, but the layout stays so I think it is ok.