[sailfish-browser] Use pulley menu for actions in tab page. #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to use a pulley menu instead of a toolbar with a menu in the tab list page.
There are three actions in the menu of this page at the moment :
I've transfered these actions into a pulley menu. The only difference is that the first action opens a new tab in the current mode and the second action opens one in the other mode while the menu is using a fixed layout whatever the mode.
I've removed the toolbar since the action of the add button is in the pulley, and the back action is a normal LtoR swipe. This allows more screen estate for the tab list without loosing actions, keeping consistency with the rest of the OS.
I've moved the tab bar switching the mode to the bottom, so it can be accessed easily one handed with the thumb. Its position at the bottom is quite consistent with the toolbar of the main page view from which we are coming from to arrive on the tab list page.
As discussed in the forum (https://forum.sailfishos.org/t/browser-redesign-in-sailfish-4-2-feedback-thread/7867/68), I guess the design decision to use a toolbar with buttons and a menu was already taken. So I hope this PR will be the occasion to discuss advantages and shortcomings of both approaches and make improvements to the tab list page design in general, whatever directions they go in. In term of raw number of lines (and maintainance), this PR simplify
TabGridView.qmlandTabView.qmla bit already ; -)@rainemak , @atatarov , @jpetrell and @mkenttala, I would appreciate your comments and views on this matter and thank you in advance for the time you may spend looking at it.