Updates test name

saket · Apr 24, 2024 · 131cc0c · 131cc0c
1 parent f999d00
commit 131cc0c
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 61 deletions.
diff --git a/...image/coil/src/androidTest/kotlin/me/saket/telephoto/zoomable/coil/CoilImageSourceTest.kt b/...image/coil/src/androidTest/kotlin/me/saket/telephoto/zoomable/coil/CoilImageSourceTest.kt
@@ -256,6 +256,67 @@ class CoilImageSourceTest {
     }
   }
 
+  @Test fun uses_updated_async_placeholder_size_when_available() = runTest {
+    val imageUrl = serverRule.server.url("/slow_placeholder_image.png")
+    lateinit var state: ZoomableImageState
+    var displayImage by mutableStateOf(false)
+    var placeholderLoaded = false
+
+    rule.setContent {
+      state = rememberZoomableImageState()
+
+      val placeholderPainter = rememberAsyncImagePainter(
+        model = ImageRequest.Builder(context)
+          .data(imageUrl)
+          .allowHardware(false) // Unsupported by Screenshot.capture()
+          .listener(
+            onSuccess = { _, _ ->
+              placeholderLoaded = true
+            }
+          )
+          .build()
+      )
+      val source = object : ZoomableImageSource {
+        @Composable
+        override fun resolve(canvasSize: Flow<Size>): ResolveResult {
+          val delegate = remember(displayImage) {
+            if (displayImage) {
+              ZoomableImageSource.SubSamplingDelegate(SubSamplingImageSource.asset("night_watch_14000.jpg"))
+            } else {
+              null
+            }
+          }
+
+          return ResolveResult(
+            delegate = delegate,
+            placeholder = placeholderPainter,
+          )
+        }
+      }
+
+      ZoomableImage(
+        modifier = Modifier
+          .fillMaxSize()
+          .testTag("image"),
+        image =  source,
+        contentDescription = null,
+        state = state,
+      )
+    }
+
+    rule.waitUntil(5.seconds) { placeholderLoaded }
+    rule.waitForIdle()
+    rule.runOnIdle {
+      dropshots.assertSnapshot(rule.activity, name = "${testName.methodName}_placeholder")
+    }
+    displayImage = true
+    rule.waitForIdle()
+    rule.waitUntil(5.seconds) { state.isImageDisplayed }
+    rule.runOnIdle {
+      dropshots.assertSnapshot(rule.activity, name = "${testName.methodName}_full_image")
+    }
+  }
+
   @Test fun reload_image_when_image_request_changes() = runTest {
     var imageUrl by mutableStateOf(serverRule.server.url("placeholder_image.png"))
 
@@ -393,67 +454,6 @@ class CoilImageSourceTest {
     }
   }
 
-  @Test fun loads_placeholder_for_subsampled_image() = runTest {
-    val imageUrl = serverRule.server.url("/slow_placeholder_image.png")
-    lateinit var state: ZoomableImageState
-    var displayImage by mutableStateOf(false)
-    var placeholderLoaded = false
-
-    rule.setContent {
-      state = rememberZoomableImageState()
-
-      val placeholderPainter = rememberAsyncImagePainter(
-        model = ImageRequest.Builder(context)
-          .data(imageUrl)
-          .allowHardware(false) // Unsupported by Screenshot.capture()
-          .listener(
-            onSuccess = { _, _ ->
-              placeholderLoaded = true
-            }
-          )
-          .build()
-      )
-      val source = object : ZoomableImageSource {
-        @Composable
-        override fun resolve(canvasSize: Flow<Size>): ResolveResult {
-          val delegate = remember(displayImage) {
-            if (displayImage) {
-              ZoomableImageSource.SubSamplingDelegate(SubSamplingImageSource.asset("night_watch_14000.jpg"))
-            } else {
-              null
-            }
-          }
-
-          return ResolveResult(
-            delegate = delegate,
-            placeholder = placeholderPainter,
-          )
-        }
-      }
-
-      ZoomableImage(
-        modifier = Modifier
-          .fillMaxSize()
-          .testTag("image"),
-        image =  source,
-        contentDescription = null,
-        state = state,
-      )
-    }
-
-    rule.waitUntil(5.seconds) { placeholderLoaded }
-    rule.waitForIdle()
-    rule.runOnIdle {
-      dropshots.assertSnapshot(rule.activity, name = "${testName.methodName}_placeholder")
-    }
-    displayImage = true
-    rule.waitForIdle()
-    rule.waitUntil(5.seconds) { state.isImageDisplayed }
-    rule.runOnIdle {
-      dropshots.assertSnapshot(rule.activity, name = "${testName.methodName}_full_image")
-    }
-  }
-
   context(TestScope)
   private fun resolve(
     canvasSize: Size = Size(1080f, 1920f),

diff --git a/...older_for_subsampled_image_full_image.png → ...holder_size_when_available_full_image.png b/...older_for_subsampled_image_full_image.png → ...holder_size_when_available_full_image.png
diff --git a/...lder_for_subsampled_image_placeholder.png → ...older_size_when_available_placeholder.png b/...lder_for_subsampled_image_placeholder.png → ...older_size_when_available_placeholder.png