Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Klibs Cross Compilation to fix #102 #115

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

vanniktech
Copy link
Contributor

Is this really all that is needed?

Copy link
Owner

@saket saket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Let's try it out! I was also hoping to test a macOS runner for running the tests on iOS, but can do that in a follow up.

@saket saket merged commit 26688cb into saket:trunk Dec 6, 2024
1 of 2 checks passed
@vanniktech vanniktech deleted the patch-1 branch December 6, 2024 10:30
@vanniktech
Copy link
Contributor Author

Does not seem to work?

Screenshot 2024-12-06 at 19 30 30

@saket
Copy link
Owner

saket commented Dec 6, 2024

Yeah, I thought I can merge this as-is while continuing to investigate the failure. That task is succeeding on my machine so I'm guessing it's a host issue. I don't think I can run iOS tests on a Ubuntu runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants