-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ソースコードの整形の実験 (PR1172 との比較用) #1179
Closed
m-tmatma
wants to merge
12
commits into
sakura-editor:master
from
m-tmatma:research/feature/EditFormatDocument-compare-point1-try
Closed
[WIP] ソースコードの整形の実験 (PR1172 との比較用) #1179
m-tmatma
wants to merge
12
commits into
sakura-editor:master
from
m-tmatma:research/feature/EditFormatDocument-compare-point1-try
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Build sakura 1.0.2585 completed (commit a69efdd28c by @m-tmatma) |
#1172 の成果として、これと比較したら差分がないと証明できるソースの塊が出来たわけですな。 この内容なら、検証コードを漏れなく取り除くのは容易なはず。 |
Merged
This was referenced Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
[WIP] ソースコードの整形の実験 (#1172 との比較用)
カテゴリ
PR の背景
#1172 の確認を行うために、アセンブリ出力の一致を確認するために
コードが変化しないようにデバッグコードを入れたもの
PR のメリット
#1172 の確認が容易になる。
PR のデメリット (トレードオフとかあれば)
なし
PR の影響範囲
関連チケット
参考資料