Implement EngagementLauncher business logic for ongoing live engagement #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavDo
commented
Jan 10, 2025
| /** | ||
| * Starts a chat engagement. | ||
| * | ||
| * @param context Activity or Context used to launch the chat screen | ||
| * @param visitorContextAssetId Optional visitor context id from Glia Hub | ||
| */ | ||
| fun startChat(context: Context, visitorContextAssetId: String? = null) | ||
| @FeatureUnderConsiderationForRemoval |
There was a problem hiding this comment.
What do you think about this solution?
As the @JvmOverloads annotation is not supported for interfaces, integrators using Java must explicitly pass null for visitorContextAssetId. For this reason, I have defined a new function instead.
Later I added this annotation to prevent integrators from using the functions with visitorContextAssetId until they need it. To do that, they have to mark their functions with the @OptIn(FeatureUnderConsiderationForRemoval::class) annotation, otherwise it won't compile.
DavDo
commented
Jan 10, 2025
| @@ -22,12 +20,19 @@ internal class HasOngoingSecureConversationUseCase( | |||
| secureConversationsRepository.unreadMessagesCountObservable, | |||
| engagementStateUseCase() | |||
| ) { pendingSecureConversations, unreadMessagesCount, state -> | |||
| isAuthenticatedUseCase() && | |||
| (pendingSecureConversations || unreadMessagesCount > 0 || state is State.TransferredToSecureConversation) | |||
| pendingSecureConversations || unreadMessagesCount > 0 || state is State.TransferredToSecureConversation | |||
There was a problem hiding this comment.
Removed the isAuthenticatedUseCase() check, as it was included in the unread_messages_count observable on the core SDK side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-3932
What was solved?
Release notes:
Additional info:
Screenshots: