Forward unhandled messages to optional subscriber handle_info callback #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmastalimaa
force-pushed
the
consumer_info_callbacks
branch
from
6de7feb to
7ed6aa7
Compare
|
I'll make a PR upstream after approved here. |
oskarkook
approved these changes
Jun 6, 2024
urmastalimaa
force-pushed
the
consumer_info_callbacks
branch
2 times, most recently
from
5eab124 to
0db2802
Compare
The motivation for adding handle_info callbacks is to allow subscriber worker processes which are spawned by brod to participate in message passing, supporting a variety of use cases utilizing async acking and committing. An example use case: * Start a group subscriber using `brod_group_subscriber_v2` * In a partition worker spawn a new process for every message under a supervisor specific to the worker's topic-partition * When the supervisor has <= N processes, ack last seen offset to fetch new messages. When the supervisor has > N processes, messages are not acked to apply backpressure * When all processes up to offset O1 have completed, commit offset O1 Allowing arbitrary message passing in the topic and group subscriber workers supports not only that use case but many others.
urmastalimaa
force-pushed
the
consumer_info_callbacks
branch
from
0db2802 to
20ca6c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for adding handle_info callbacks is to allow subscriber worker processes which are spawned by brod to participate in message passing, supporting a variety of use cases utilizing async acking and committing.
An example use case:
brod_group_subscriber_v2Allowing arbitrary message passing in the topic and group subscriber workers supports not only that use case but many others.