Improvements to pact verification #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 27, 2024 15:16
Previously the path to ebin did not work properly when a different folder structure was used. This makes sure that it targets the correct folder. (In future commits, this could even be a parameter, for better configurability)
OutputLog contains useful information about what happens with Pact verification.
fcaldera
approved these changes
May 29, 2024
This is useful if the provider wants to use real authentication flow for the contract tests. Disclaimer: `pactffi_verifier_add_custom_header` function unfortunately is not able to override an existing header, so using this requires the pact to not include the authorization header in the first place. This can either be done by simply not using it on the consumer-side test or removing it somehow before publishing the pact. Although I worked through the following issues: - pact-foundation/pact-net#460 - pact-foundation/pact-reference#275 from which the latter is actually marked as closed, and the fix is allegedly included in the pact-ffi version that we use, it still did not override an existing header. I tried bumping to a higher version as well but without any luck. I will create an issue to pact-foundation to try to get clarity on this.
|
Created an issue to pact about the header overwriting problem pact-foundation/pact-reference#430 |
This reverts commit d75d6ba. Reason: I actually found anther way of replacing the authorization header: - Use `fromProviderState` Matcher function on consumer side for auth header. Match `Bearer ${authToken}`, use JWT regex - On provider side, in state change URL endpoint, generate the token and return it in the callback under `authToken` - The provider-generated auth token will be used in the request. I am leaving this as commit + revert for future reference purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
add_pathzinput in thepact_escriptmodule to use the correct path.Added the ability to pass custom auth tokensFurther details in commit messages.
Fixes: greyorange-labs#39 greyorange-labs#32
Checklist:
make formatto format the code according to guidelines