OrderLine metadata UI improvements #5432
Open
+577
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix-order-line-metadata #5432 +/- ##
===========================================================
+ Coverage 62.31% 62.38% +0.06%
===========================================================
Files 1275 1277 +2
Lines 22107 22140 +33
Branches 4394 4401 +7
===========================================================
+ Hits 13775 13811 +36
+ Misses 8293 8290 -3
Partials 39 39 ☔ View full report in Codecov by Sentry. |
3 tasks
witoszekdev
force-pushed
the
order-line-metadata-ui-improvements
branch
from
fa88512 to
7cae4db
Compare
witoszekdev
force-pushed
the
order-line-metadata-ui-improvements
branch
from
83ce814 to
945da81
Compare
Differences Found✅ No packages or licenses were added. SummaryExpand
|
poulch
reviewed
Feb 26, 2025
| const { action, field, fieldIndex, value } = parseEventData(event); | ||
| const key = getDataKey(isPrivate); | ||
| const dataToUpdate = data[key]; | ||
| export const MetadataNoMemo: React.FC<MetadataProps> = ({ |
There was a problem hiding this comment.
question: Is it any sens to have exported two component memenoize and not?
Comment on lines
+59
to
+77
| action === EventDataAction.update | ||
| ? updateAtIndex( | ||
| { | ||
| ...dataToUpdate[fieldIndex], | ||
| key: field === EventDataField.name ? value : dataToUpdate[fieldIndex].key, | ||
| value: field === EventDataField.value ? value : dataToUpdate[fieldIndex].value, | ||
| }, | ||
| dataToUpdate, | ||
| fieldIndex, | ||
| ) | ||
| : action === EventDataAction.add | ||
| ? [ | ||
| ...dataToUpdate, | ||
| { | ||
| ...dataToUpdate[fieldIndex], | ||
| key: field === EventDataField.name ? value : dataToUpdate[fieldIndex].key, | ||
| value: field === EventDataField.value ? value : dataToUpdate[fieldIndex].value, | ||
| key: "", | ||
| value: "", | ||
| }, | ||
| dataToUpdate, | ||
| fieldIndex, | ||
| ) | ||
| : action === EventDataAction.add | ||
| ? [ | ||
| ...dataToUpdate, | ||
| { | ||
| key: "", | ||
| value: "", | ||
| }, | ||
| ] | ||
| : removeAtIndex(dataToUpdate, fieldIndex), | ||
| }, | ||
| }); | ||
| }; | ||
| ] | ||
| : removeAtIndex(dataToUpdate, fieldIndex), |
There was a problem hiding this comment.
suggestion: I'd extract this to external function and create at least map action name to handler and then use it like that fun getActionType(type) => map[actionType]
Comment on lines
+82
to
+96
| return ( | ||
| <Box display="grid" gap={2} paddingBottom={10} {...props}> | ||
| {isLoading ? ( | ||
| <> | ||
| <MetadataLoadingCard /> | ||
| {!hidePrivateMetadata && <MetadataLoadingCard isPrivate />} | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <MetadataCard | ||
| data={data?.metadata} | ||
| isPrivate={false} | ||
| readonly={readonly} | ||
| onChange={event => change(event, false)} | ||
| /> |
There was a problem hiding this comment.
suggestion: avoid tenary expression inside render
Suggested change
| return ( | |
| <Box display="grid" gap={2} paddingBottom={10} {...props}> | |
| {isLoading ? ( | |
| <> | |
| <MetadataLoadingCard /> | |
| {!hidePrivateMetadata && <MetadataLoadingCard isPrivate />} | |
| </> | |
| ) : ( | |
| <> | |
| <MetadataCard | |
| data={data?.metadata} | |
| isPrivate={false} | |
| readonly={readonly} | |
| onChange={event => change(event, false)} | |
| /> | |
| if (isLoading) { | |
| <Box display="grid" gap={2} paddingBottom={10} {...props}> | |
| <MetadataLoadingCard /> | |
| {!hidePrivateMetadata && <MetadataLoadingCard isPrivate />} | |
| </Box> | |
| } | |
| return ( | |
| <Box display="grid" gap={2} paddingBottom={10} {...props}> | |
| ... | |
| </Box> | |
| ) |
| readonly={readonly} | ||
| onChange={event => change(event, false)} | ||
| /> | ||
| {(data?.privateMetadata || !hidePrivateMetadata) && ( |
There was a problem hiding this comment.
suggestion: IMO this condition is wrong, shouldn't always show privite metadata even when empty !hidePrivateMetadata?
| import React from "react"; | ||
| import { useIntl } from "react-intl"; | ||
|
|
||
| const ListValue = ({ children, last }: { children: React.ReactNode; last?: boolean }) => { |
There was a problem hiding this comment.
suggestion: please use direct import from react import {ReactNode} from "react"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR scope
New UI
Improve OrderLine metadata dialog to have information about the order line (SKU, image, quantity, variant name)
Modal fixes
Fixes issues with OrderLine metadata dialog not preventing clicks made outside of dialog, when cursor was hovering DataGrid interactive elements (e.g.
View metadatabutton):Before
After
Fetching
Metadata is now fetched on modal open (always refetches latest metadata, due to API constraints it's metadata for all order lines)