add build docker image #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @mrchypark to sign the Salesforce.com Contributor License Agreement. |
|
I signed license |
|
Any updates on this? It would be nice to have the image on dockerhub. |
bman46
reviewed
May 15, 2023
| id: docker_meta | ||
| uses: crazy-max/[email protected] | ||
| with: | ||
| images: mrchypark/generic-sidecar-injector |
There was a problem hiding this comment.
I dont think that the main repo should have mrchypark here. Maybe use a variable/secret instead?
There was a problem hiding this comment.
I would appreciate it if you could kindly provide me with the necessary repository address. I do not have authorization for the Salesforce organization. The changes I made were done using my personal account based on my needs, so please make the appropriate modifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add docker image build github action.
you need to change trigger setting and image name.
I prefer triggering tags startwith v and simver like v0.0.5 and now action set 0.0.5 image tag.
And you need to set docker hub secret name DOCKERHUB_USERNAME and DOCKERHUB_TOKEN.