Migrate webhook admission controller from v1beta1 to v1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @maciejkoluda-tomtom to sign the Salesforce.com Contributor License Agreement. |
|
I've signed cla. This pr contains fix for #34 |
|
up |
|
@maciejkoluda-tomtom can you sign the cla again. the check is failing/ |
|
hi @krmayankk, Then, when I click on "Login via GitHub to sign the CLA" I get: Could you check it on your side, please? Maybe invalidate it, and I will try to sign it again. |
|
@maciejkoluda-tomtom I looked at your branch, and I was unable to build it because it seems the go deps are not updated for v1. |
This was referenced Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.