Fix crash due to incorrect condition variable usage #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeList::Flush
callednotify_all
. After the waiter (in this case, the main thread) is woken up,notify_all
might not have returned just yet. If the main thread proceeded and calledClear
on theChangeList
object in the meantime, the condition variable is deleted whennotify_all
is still executing, causing a crash. This occurs frequently on my machine when running the tool in "branching mode", and there are changelists happening on lots of "uninteresting" branches (in other words: changelists with 0 files to be committed).ChangeList
class is reworked: instead of multiple atomic variables, mutexes, and condition variables, a single condition variable and mutex is used, with a state machine.