Merge pull request #825 from salesforcecli/sm/read-only-auth-info

refactor: not mutate authinfo.getFields object
salesforcecli · Oct 13, 2023 · bda72e2 · bda72e2
2 parents 8355a29 + 4f45118
commit bda72e2
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/commands/org/login/sfdx-url.ts b/src/commands/org/login/sfdx-url.ts
@@ -90,9 +90,8 @@ export default class LoginSfdxUrl extends AuthBaseCommand<AuthFields> {
       setDefaultDevHub: flags['set-default-dev-hub'],
     });
 
-    const result = authInfo.getFields(true);
     // ensure the clientSecret field... even if it is empty
-    result.clientSecret = result.clientSecret ?? '';
+    const result = { clientSecret: '', ...authInfo.getFields(true) };
     await AuthInfo.identifyPossibleScratchOrgs(result, authInfo);
 
     const successMsg = commonMessages.getMessage('authorizeCommandSuccess', [result.username, result.orgId]);