Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update auth table and dependencies #1173

Merged
merged 7 commits into from
Oct 21, 2024
Merged

fix: update auth table and dependencies #1173

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04f8a6b
fix: update auth table and dependencies
soridalac Oct 18, 2024
f9d7d8d
fix: package conflict
soridalac Oct 21, 2024
3a0a224
fix: update change for table
soridalac Oct 21, 2024
d26260b
chore: review code
mdonnalley Oct 21, 2024
bf7a35a
fix: update dependencies
soridalac Oct 21, 2024
9f25082
Merge pull request #1178 from salesforcecli/mdonnalley/pr-review
soridalac Oct 21, 2024
b6ba3cd
chore: bump sf-plugins-core
mdonnalley Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"@oclif/core": "^4",
"@salesforce/core": "^8.6.2",
"@salesforce/kit": "^3.2.3",
"@salesforce/plugin-info": "^3.4.12",
"@salesforce/sf-plugins-core": "^11.3.10",
"@salesforce/plugin-info": "^3.4.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this dependency going backwards? 12->9?

"@salesforce/sf-plugins-core": "^12",
"@salesforce/ts-types": "^2.0.11",
"open": "^10.1.0"
},
Expand Down
21 changes: 12 additions & 9 deletions src/commands/org/list/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,19 @@ export default class ListAuth extends SfCommand<AuthListResults> {
});

const hasErrors = auths.filter((auth) => !!auth.error).length > 0;
const columns = {
alias: { header: 'ALIAS' },
username: { header: 'USERNAME' },
orgId: { header: 'ORG ID' },
instanceUrl: { header: 'INSTANCE URL' },
oauthMethod: { header: 'AUTH METHOD' },
...(hasErrors ? { error: { header: 'ERROR' } } : {}),
};
this.styledHeader('authenticated orgs');
this.table(mappedAuths, columns);

this.table({
data: mappedAuths,
columns: [
{ key: 'alias', name: 'ALIAS' },
{ key: 'username', name: 'USERNAME' },
{ key: 'orgId', name: 'ORG ID' },
{ key: 'instanceUrl', name: 'AUTH METHOD' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be { key: 'instanceUrl', name: 'INSTANCE URL' }

{ key: 'oauthMethod', name: 'AUTH METHOD' },
hasErrors ? { key: 'error', name: 'ERROR' } : 'error',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error shouldn't be in the columns array if hasErrors is false

],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

title: 'authenticated orgs'

and remove this.styledHeader('authenticated orgs') just above this

});
return mappedAuths;
} catch (err) {
this.log(messages.getMessage('noResultsFound'));
Expand Down
Loading
Loading