Wr/tables #823
Merged
Wr/tables #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
force-pushed
the
wr/tables
branch
from
6d56437 to
6542c9c
Compare
mdonnalley
approved these changes
Oct 30, 2024
mdonnalley
requested changes
Oct 30, 2024
src/commands/package/create.ts
Outdated
| @@ -94,6 +94,6 @@ export class PackageCreateCommand extends SfCommand<PackageCreate> { | |||
|
|
|||
| private display(result: PackageCreate): void { | |||
| this.styledHeader('Ids'); | |||
| this.table([{ name: 'Package Id', value: result.Id }], { name: { header: 'NAME' }, value: { header: 'VALUE' } }); | |||
| this.table({ data: [{ name: 'Package Id', value: result.Id }] }); | |||
There was a problem hiding this comment.
you should use the title prop now,
this.table({
data,
title: 'Ids',
})
| key: { header: 'Name' }, | ||
| value: { header: 'Value' }, | ||
| }); | ||
| this.table({ data }); |
There was a problem hiding this comment.
replace this.styledHeader by passing in the title prop to this.table
| ...(flags.verbose ? { 'Version Name': r.VersionName, 'Version Number': r.VersionNumber } : {}), | ||
| })); | ||
|
|
||
| this.table({ data, overflow: 'wrap' }); |
There was a problem hiding this comment.
replace this.styledHeader by passing in the title prop to this.table
| @@ -214,8 +215,10 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma | |||
| }); | |||
| }); | |||
| this.styledHeader(`Package Versions [${results.length}]`); | |||
| this.table(results, getColumnData(flags.concise, flags.verbose, flags['show-conversions-only']), { | |||
| 'no-truncate': true, | |||
| this.table({ | |||
There was a problem hiding this comment.
replace this.styledHeader by passing in the title prop to this.table
src/commands/package/list.ts
Outdated
|
|
||
| this.table(results, columns); | ||
| })); | ||
| this.table({ data }); |
There was a problem hiding this comment.
replace this.styledHeader by passing in the title prop to this.table
| @@ -213,9 +213,9 @@ export class PackageVersionReportCommand extends SfCommand<PackageVersionReportR | |||
| displayCoverageRecords.splice(0, displayCoverageRecords.length); | |||
| } | |||
| this.styledHeader(chalk.blue('Package Version')); | |||
| this.table(displayRecords, { key: { header: 'Name' }, value: { header: 'Value' } }); | |||
| this.table({ data: displayRecords }); | |||
There was a problem hiding this comment.
replace this.styledHeader by passing in the title prop to this.table
|
QA 🟢 🟢 🟢 🟢 🟡 This doesn't look great even if you use the The problem is that the table is designed to never truncate or wrap table headers, which in retrospect wasn't a great decision. I can make a PR to modify that 🟢 |
mdonnalley
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updates to new sf-plugins-core
updates tables
fixes message string without template string
What issues does this PR fix or reference?
@W-16736199@