Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support interned structs without lifetimes #618

Conversation

davidbarsky
Copy link
Contributor

For background context, see Zulip, but the long-and-short of it is that the 'db lifetime on interned values made porting rust-analyzer to the new Salsa nearly impossible. However, I realized that I could simply get rid of the 'db lifetime on interned structs, hence this PR.

I also ported over the interned-struct tests.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 60ca556
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/6761984d1cdd2c000819de70

Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #618 will not alter performance

Comparing davidbarsky:davidbarsky/interning-without-lifetimes (60ca556) with master (3c7f169)

Summary

✅ 9 untouched benchmarks

@MichaReiser
Copy link
Contributor

MichaReiser commented Nov 27, 2024

I don't mind this, but I would prefer to have all the backwards compat macros behind an off-by-default feature flag to prevent new users from starting to use them.

@davidbarsky
Copy link
Contributor Author

Closed in favor of #632.

@davidbarsky davidbarsky deleted the davidbarsky/interning-without-lifetimes branch December 18, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants