Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Option around Storage::zalsa_impl #645

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 4, 2025

We can enforce the drop order via generated drop glue instead

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 8952c4d
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/677a529107a46a00086352e7

Copy link

codspeed-hq bot commented Jan 4, 2025

CodSpeed Performance Report

Merging #645 will not alter performance

Comparing Veykril:veykril/push-lylvllzxsmkr (8952c4d) with master (6c0dd82)

Summary

✅ 9 untouched benchmarks

@Veykril Veykril force-pushed the veykril/push-lylvllzxsmkr branch from 5500c1b to 0c5bc2d Compare January 4, 2025 15:31
src/storage.rs Outdated Show resolved Hide resolved
We can enforce the drop order via generated drop glue instead.
@Veykril Veykril force-pushed the veykril/push-lylvllzxsmkr branch from 0c5bc2d to 8952c4d Compare January 5, 2025 09:36
@Veykril Veykril added this pull request to the merge queue Jan 5, 2025
Merged via the queue into salsa-rs:master with commit 5943356 Jan 5, 2025
8 of 9 checks passed
@Veykril Veykril deleted the veykril/push-lylvllzxsmkr branch January 5, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants