feat: made yamlcheck output more consistent

salsadigitalauorg · Feb 14, 2024 · 568dc14 · 568dc14
1 parent f6495cf
commit 568dc14
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/checks/drupal/drushyamlcheck_test.go b/pkg/checks/drupal/drushyamlcheck_test.go
@@ -177,7 +177,7 @@ func TestDrushYamlCheckRunCheck(t *testing.T) {
 			},
 			ExpectFails: []result.Breach{&result.KeyValueBreach{
 				BreachType:    "key-value",
-				KeyLabel:      "core.extension",
+				KeyLabel:      "config:core.extension",
 				Key:           "profile",
 				ValueLabel:    "actual",
 				Value:         "minimal",

diff --git a/pkg/checks/yaml/yaml.go b/pkg/checks/yaml/yaml.go
@@ -76,7 +76,7 @@ func (c *YamlBase) determineBreaches(configName string) {
 			})
 		case KeyValueNotEqual:
 			c.AddBreach(&result.KeyValueBreach{
-				KeyLabel:      configName,
+				KeyLabel:      "config:" + configName,
 				Key:           kv.Key,
 				ValueLabel:    "actual",
 				ExpectedValue: kv.Value,

diff --git a/pkg/checks/yaml/yaml_test.go b/pkg/checks/yaml/yaml_test.go
@@ -337,9 +337,9 @@ notification:
 	c.Result.DetermineResultStatus(false)
 	assert.Equal(result.Fail, c.Result.Status)
 	assert.EqualValues(0, len(c.Result.Passes))
-	assert.ElementsMatch([]result.Breach{&result.KeyValueBreach{
+	assert.EqualValues([]result.Breach{&result.KeyValueBreach{
 		BreachType:    result.BreachTypeKeyValue,
-		KeyLabel:      "data",
+		KeyLabel:      "config:data",
 		Key:           "check.interval_days",
 		ValueLabel:    "actual",
 		Value:         "7",