fix: simplify filecheck breach message

salsadigitalauorg · Feb 14, 2024 · 649c4b8 · 649c4b8
1 parent aee8cf0
commit 649c4b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkg/checks/file/filecheck.go b/pkg/checks/file/filecheck.go
@@ -1,7 +1,6 @@
 package file
 
 import (
-	"fmt"
 	"path/filepath"
 	"strings"
 
@@ -66,7 +65,7 @@ func (c *FileCheck) RunCheck() {
 		return
 	}
 	c.AddBreach(&result.ValueBreach{
-		ValueLabel: fmt.Sprintf("%s - illegal files found", c.Name),
-		Value:      strings.Join(files, "\n"),
+		ValueLabel: "illegal files found",
+		Value:      strings.Join(files, ","),
 	})
 }
diff --git a/pkg/checks/file/filecheck_test.go b/pkg/checks/file/filecheck_test.go
@@ -86,8 +86,8 @@ func TestFileCheckRunCheck(t *testing.T) {
 				CheckType:  "file",
 				CheckName:  "filecheck2",
 				Severity:   "normal",
-				ValueLabel: "filecheck2 - illegal files found",
-				Value:      "testdata/adminer.php\ntestdata/sub/phpmyadmin.php",
+				ValueLabel: "illegal files found",
+				Value:      "testdata/adminer.php,testdata/sub/phpmyadmin.php",
 			},
 		},
 		c.Result.Breaches,