[DEVOPS-646] Refactor all output into plugins similar to Fact & Analyse #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusufhm
force-pushed
the
feature/DEVOPS-646-lagoon-problems-source
branch
from
52b7b3d to
32cf1d5
Compare
yusufhm
force-pushed
the
feature/DEVOPS-646-lagoon-problems-source
branch
from
87fe4b3 to
60c024a
Compare
Even though the env vars were being set in an earlier command, they were not being used in `go build`. Moving them to the actual command is what works.
steveworley
reviewed
Oct 21, 2024
| @@ -0,0 +1,141 @@ | |||
| package lagoon | |||
There was a problem hiding this comment.
Hmmm — this is a difficult choice, I like how we have the output package. It clearly illustrates what is an output plugin. However, problems being specific to Lagoon pose a bit of an issue with the convention.
We can leave it here for now, but I'm wondering if we want to make it part of the output package for consistency.
There was a problem hiding this comment.
It might make more sense in the future when actually implementing the plugin system - see the sample here: #69
steveworley
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
lagoon-sourceflag when pushing Problems to Insights.This PR introduces the interface & plugin system for Output, similar to how Fact & Analyse plugins are done.
Two new such interfaces are introduced:
Stdout&Lagoon